Thread (23 messages) 23 messages, 4 authors, 9h ago

Re: [PATCH GSoC 4/5] serve: advertise type capability

From: Chandra Pratap <hidden>
Date: 2026-07-29 09:58:30

[snip]
-# This tests depends on %(objecttype) not being supported yet, once supported
-# it needs to be updated.
-test_expect_success 'unsupported placeholder on remote returns empty string' '
+test_expect_success 'objecttype is supported by remote-object-info' '
        (
                set_transport_variables "$daemon_parent" &&
                cd "$daemon_parent/daemon_client_empty" &&

-               echo "" >expect &&
+               echo $hello_type >expect &&
                git cat-file --batch-command="%(objecttype)" >actual <<-EOF &&
                remote-object-info "$GIT_DAEMON_URL/parent" $hello_oid
                EOF
Instead of this, what about creating a single test that verifies
'type' is supported,
and modifying this test to verify that the other options are not?

That would actually preserve this test's behaviour and make it easier
to extend in the future. Something like:

+ test_expect_success 'type is supported by remote-object-info'
+ test_expect_success 'unsupported placeholder on remote returns empty string'
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help