Thread (37 messages) flat view 37 messages, 6 authors, 2016-06-15

Re: [PATCH] Add a new lstat and fstat implementation based on Win32 API

From: Marius Storm-Olsen <hidden>
Date: 2016-06-15 22:43:33

Possibly related (same subject, not in this thread)

Johannes Sixt wrote:
Johannes Sixt schrieb:
quoted
Marius Storm-Olsen schrieb:
quoted
Johannes Schindelin wrote:
quoted
To make it easier on others, I just uploaded it into the
"teststat" branch on 4msysgit.git (subject to removal in a few
days).
Ok, I've updated the patch in the 4msysgit.git repo, 'teststat'
branch. RFC, and please test.
Thanks a lot! I've pushed it out in mingw.git's master.

The reason that t4200-rerere.sh fails is that we now store UTC in 
st_mtime. However, for the garbage-collection we compare this entry
to a local time stamp.
This analysis is incorrect, I think. The reason we fail seems to be
that t4200 uses test-chmtime, which uses utime(). Likely, we need a
wrapper for that one?
Ok, could you make a quick patch to add a git_utime() (and probably
git_time()) and see if the tests pass without the UTC to Local time patch?

--
.marius

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help