Re: [PATCH] Add a new lstat and fstat implementation based on Win32 API

Johannes Schindelin schrieb:

Hi,

On Tue, 4 Sep 2007, Johannes Sixt wrote:

quoted

Marius Storm-Olsen schrieb:

quoted

Marius Storm-Olsen said the following on 04.09.2007 13:53:

quoted

In the meantime, I've pushed out a new patch
http://repo.or.cz/w/git/mingw/4msysgit.git?a=commitdiff;h=683775c00d9fb95bcbe4632f95b67a96b902fa59 

/me starts another test run, to see how our tests are doing now..

Neat, with the custom stat() changes cherry-picked on top of 4msysgit.git
'devel' branch, I only have one failing testcase
    t6024-recursive-merge.sh
when running
    $ NO_SYMLINKS=1 make -k

The rest are passing with flying colors!

And that one will eventually pass if only you try it often enough. See
71ee4210c in mingw.git.

Do you have Linus' patch applied?  The one where the config is read at the 
start of write-tree?

The problem only occurred since we have core.crlf = input unilaterally 
now.

Yes, I have that patch, but I don't have core.crlf set.

There are a lot of tests that do a series of commits in a row, with file 
changes such that the file size does _not_ change, aka "racy git" problem. 
This problem is obviously not 100% fixed on MSys: We do not correctly detect 
that there are files that might be modified ("racily clean" files). Some 
tests are prone to trigger the bug, others not.

-- Hannes