Thread (37 messages) flat view 37 messages, 6 authors, 2016-06-15

Re: [PATCH] Add a new lstat and fstat implementation based on Win32 API

From: Marius Storm-Olsen <hidden>
Date: 2016-06-15 22:43:33

Possibly related (same subject, not in this thread)

Johannes Schindelin wrote:
On Tue, 4 Sep 2007, Marius Storm-Olsen wrote:
quoted
Neat, with the custom stat() changes cherry-picked on top of
4msysgit.git 'devel' branch, I only have one failing testcase 
t6024-recursive-merge.sh when running $ NO_SYMLINKS=1 make -k

The rest are passing with flying colors!
Bad news.  I do not know if it was the newest version I tried, but I
could no longer fetch... said something about some bad file.
Then you're missing this patch:
http://repo.or.cz/w/git/mingw/4msysgit.git?a=commitdiff;h=f15974add93bdfa92775c77c00e7c65aefd42127

I guess the quickest way is to manually apply this patch and recompile.
(or add the '#undef fstat', and have git_fstat just 'return fstat(fd, buf)')

The problem is that without this patch fstat(0, buf) would fail with bad
filedescriptor instead of returning the st_mode = S_IFIFO.

--
.marius

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help