Re: [PATCH] Add a new lstat and fstat implementation based on Win32 API

Johannes Sixt said the following on 04.09.2007 13:36:

Johannes Schindelin schrieb:

quoted

On Tue, 4 Sep 2007, Johannes Sixt wrote:

quoted

Therefore, I've pushed out a fixup patch at the top of
mingw.git's devel branch that converts mtime to local time

On Linux, we compare to UTC to begin with, right?  We should do
that here, too...  So if time(NULL) does not return UTC on MinGW,
we have to wrap that function, too.

According to MSDN, time(NULL) returns "the number of seconds
elapsed since [epoch] according to the system clock". Please don't
ask me what "the system clock" is.

Reading the implementation of time(), it starts with
GetLocalTime(), determines whether daylight saving is in effect,
and continues with another round of timezone adjustment - mind you:
_not_ a timezone reversal (!!). Doesn't this look extremely bogus?

It seems we really need a wrapper for time().

Hmm, could be.
In the meantime, I've pushed out a new patch
http://repo.or.cz/w/git/mingw/4msysgit.git?a=commitdiff;h=683775c00d9fb95bcbe4632f95b67a96b902fa59

/me starts another test run, to see how our tests are doing now..

-- 
.marius