On 29-Jan-21 2:20 PM, Thomas Monjalon wrote:

22/01/2021 18:12, Anatoly Burakov:

quoted

Things of note:

- Only 1:1 core to queue mapping is supported, meaning that each lcore
   must at most handle RX on a single queue

Is there a way to have a more generic solution?
I think it may deserve some comments in the API.

If you're referring to possibility of monitoring multiple queues from 
one core, we are investigating ways to make that happen, but for now, 
this is the limitation.

quoted

- Support 3 type policies. Monitor/Pause/Frequency Scaling
- Power management is enabled per-queue
- The API doesn't extend to other device types

Could it be extended to more device types?
Otherwise it should be called specifically ethdev power management.

It can theoretically be extended to any device type that has callbacks. 
Current focus is obviously NICs, but in general, it doesn't have to be. 
Anything that polls and has callbacks should work.

quoted

Anatoly Burakov (2):
   eal: rename power monitor condition member
   eal: improve comments around power monitoring API

Liang Ma (2):
   power: add PMD power management API and callback
   examples/l3fwd-power: enable PMD power mgmt

Applied with few formatting improvements, thanks

Thanks!

-- 
Thanks,
Anatoly