On 18-Jan-21 10:26 PM, Thomas Monjalon wrote:

14/01/2021 15:46, Anatoly Burakov:

quoted

+struct rte_power_monitor_cond {
+	volatile void *addr;  /**< Address to monitor for changes */
+	uint64_t val;         /**< Before attempting the monitoring, the address
+	                       *   may be read and compared against this value.

"may" be read and compared?
Is there a case where there is no read and compare?

Yes, if the mask is not set.

quoted

+	                       **/
+	uint64_t mask;   /**< 64-bit mask to extract current value from addr */
+	uint8_t data_sz; /**< Data size (in bytes) that will be used to compare
+	                  *   expected value with the memory address. Can be 1,
+	                  *   2, 4, or 8. Supplying any other value will lead to
+	                  *   undefined result. */

Other parameters are not prefixed with "data_",
so I think this field could be simply named "size".

OK.

quoted

+};

I understand this struct is a direct translation of what existed
in 20.11 as function parameters and comments.
If you agree, these comments could be addressed in a separate patch.

I'll be respinning anyway, so might as well do some quick fixups.

-- 
Thanks,
Anatoly