Re: [dpdk-dev] [PATCH v16 03/11] eal: change API of power intrinsics
From: Burakov, Anatoly <hidden>
Date: 2021-01-13 17:22:30
From: Burakov, Anatoly <hidden>
Date: 2021-01-13 17:22:30
On 13-Jan-21 1:01 PM, Ananyev, Konstantin wrote:
quoted
Instead of passing around pointers and integers, collect everything into struct. This makes API design around these intrinsics much easier. Signed-off-by: Anatoly Burakov <redacted> Acked-by: Konstantin Ananyev <redacted> --- Notes: v16: - Add error handlingThere are few trivial checkpatch warnings, please check
To paraphrase Nick Fury, I recognize that checkpatch has produced warnings, but given that i don't agree with what checkpatch has to say in this case, I've elected to ignore it :) In particular, these warnings related to comments around struct members, which i think i've made to look nice and also took care of correct indentation in terms of code looking the same way with different tab widths. So, i don't think it should be changed, unless you're suggesting to re-layout comments on top of each member, rather than at the side (which i think is more readable). -- Thanks, Anatoly