Re: [dpdk-dev] [PATCH v12 06/11] ethdev: add simple power management API
From: Lance Richardson <hidden>
Date: 2021-01-12 20:32:16
On Thu, Dec 17, 2020 at 9:08 AM Anatoly Burakov [off-list ref] wrote:
From: Liang Ma <redacted> Add a simple API to allow getting the monitor conditions for power-optimized monitoring of the RX queues from the PMD, as well as release notes information. Signed-off-by: Liang Ma <redacted> Signed-off-by: Anatoly Burakov <redacted> Acked-by: Konstantin Ananyev <redacted> ---
<snip>
quoted hunk ↗ jump to hunk
/** * @internal A structure containing the functions exported by an Ethernet driver. */@@ -917,6 +937,8 @@ struct eth_dev_ops { /**< Set up the connection between the pair of hairpin queues. */ eth_hairpin_queue_peer_unbind_t hairpin_queue_peer_unbind; /**< Disconnect the hairpin queues of a pair from each other. */ + eth_get_monitor_addr_t get_monitor_addr; + /**< Get next RX queue ring entry address. */ };
The implementation of get_monitor_addr will have much in common with the rx_descriptor_status API in struct rte_eth_dev, including the property that it will likely not make sense for it to be called concurrently with rx_pkt_burst on a given queue. Might it make more sense to have this API in struct rte_eth_dev instead of struct eth_dev_ops?