Re: [PATCH] service: add corelist to EAL arguments

From: Ananyev, Konstantin
Sent: Monday, July 17, 2017 4:54 PM
To: Van Haaren, Harry <redacted>; dev@dpdk.org
Cc: thomas@monjalon.net; jerin.jacob@caviumnetworks.com; Van Haaren, Harry
[off-list ref]
Subject: RE: [dpdk-dev] [PATCH] service: add corelist to EAL arguments

Hi Harry,

quoted

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Harry van Haaren
Sent: Monday, July 17, 2017 4:22 PM
To: dev@dpdk.org
Cc: thomas@monjalon.net; jerin.jacob@caviumnetworks.com; Van Haaren, Harry

[off-list ref]

quoted

Subject: [dpdk-dev] [PATCH] service: add corelist to EAL arguments

This commit allows the -S (captial 's') to be used to indicate
a corelist for Services. This is a "nice to have" patch, and does
not modify any of the service core functionality.

Suggested-by: Jerin Jacob <redacted>
Suggested-by: Thomas Monjalon <redacted>
Signed-off-by: Harry van Haaren <redacted>
---
 lib/librte_eal/common/eal_common_options.c | 74 ++++++++++++++++++++++++++++++
 1 file changed, 74 insertions(+)

diff --git a/lib/librte_eal/common/eal_common_options.c

b/lib/librte_eal/common/eal_common_options.c

quoted

index 00265d6..696a627 100644

--- a/lib/librte_eal/common/eal_common_options.c
+++ b/lib/librte_eal/common/eal_common_options.c

@@ -65,6 +65,7 @@ eal_short_options[] =
 	"d:" /* driver */
 	"h"  /* help */
 	"l:" /* corelist */
+	"S:" /* service corelist */
 	"m:" /* memory size */
 	"n:" /* memory channels */
 	"r:" /* memory ranks */

@@ -402,6 +403,72 @@ eal_parse_coremask(const char *coremask)
 }

Do we need a new parsing function here?
Can't we reuse at least part of '-l' parsing code?
Konstantin

Yep we should - in this instance (post-RC2..) I don't want to rock-the-boat and change any existing EAL functionality.

During review of eventdev-sample-app and service-cores, Jerin had noted that we are duplicating various functions for parsing strings, and really we should cleanup into a single function to call from all of them. That should be scheduled as post 17.08 rework.