Re: [PATCH v4 0/7] service cores: cover letter

-----Original Message-----

Date: Mon, 10 Jul 2017 08:18:33 +0000
From: "Van Haaren, Harry" <redacted>
To: Thomas Monjalon <redacted>
CC: "dev@dpdk.org" <redacted>, "jerin.jacob@caviumnetworks.com"
 [off-list ref], "Wiles, Keith" [off-list ref],
 "Richardson, Bruce" [off-list ref]
Subject: RE: [dpdk-dev] [PATCH v4 0/7] service cores: cover letter

quoted

From: Thomas Monjalon [mailto:thomas@monjalon.net]
Sent: Sunday, July 9, 2017 11:09 PM
To: Van Haaren, Harry <redacted>
Cc: dev@dpdk.org; jerin.jacob@caviumnetworks.com; Wiles, Keith <redacted>;
Richardson, Bruce [off-list ref]
Subject: Re: [dpdk-dev] [PATCH v4 0/7] service cores: cover letter

07/07/2017 18:41, Harry van Haaren:

quoted

v4:
- Range of fixes as suggested by Jerin
- Improved unit tests, ensuring ex-service cores become available to app
- Added functions to EXPERIMENTAL tag in .map files (Thomas)
- Added @warning experimental notes to Doxygen API documentation (Thomas)
- Various smaller fixes / cleanups
- See commit notes for details

I feel we need to wait approval from some reviewers, at least from Jerin
who was very active on this series.

Agreed that more reviewing eyes would be good.

quoted

It means it misses the first release candidate, and it is a problem
because this feature is updating the core.

Correct service cores does update the core, however a review of the code-paths
taken if the service cores -s switch is not used shows that it will have almost
no impact on the EAL code path.

quoted

Naive question: do we really want it in 17.08?

I think merging in 17.08 allow us to progress on integrating services and DPDK, so I see value in including in this release.

+1