Re: [PATCH v3 5/7] service cores: enable event/sw with service
From: Van Haaren, Harry <hidden>
Date: 2017-07-07 16:28:30
From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] Sent: Tuesday, July 4, 2017 11:53 AM To: Van Haaren, Harry <redacted> Cc: dev@dpdk.org; thomas@monjalon.net; Wiles, Keith <redacted>; Richardson, Bruce [off-list ref] Subject: Re: [PATCH v3 5/7] service cores: enable event/sw with service -----Original Message-----quoted
Date: Sun, 2 Jul 2017 22:35:12 +0100 From: Harry van Haaren <redacted> To: dev@dpdk.org CC: jerin.jacob@caviumnetworks.com, thomas@monjalon.net, keith.wiles@intel.com, bruce.richardson@intel.com, Harry van Haaren [off-list ref] Subject: [PATCH v3 5/7] service cores: enable event/sw with service X-Mailer: git-send-email 2.7.4 This commit shows how easy it is to enable a specific DPDK component with a service callback, in order to get CPU cycles for it. The beauty of this method is that the service is unaware of how much CPU time it is getting - the application can decide how to split and slice cores and map them to the registered services. Signed-off-by: Harry van Haaren <redacted>
<snip>
quoted
+ + /* check a service core is mapped to this service */ + struct rte_service_spec *s = rte_service_get_by_name(sw->service_name); + if (!rte_service_is_running(s)) + SW_LOG_ERR("Warning: No Service core enabled on service %s\n", + s->name);For now, we can print just Warning. Once we remove schedule api from eventdev then we can make it as error. Right?
Yes correct.
Acked-by: Jerin Jacob <redacted>
Thanks, will include in v+1.