Re: [PATCH v4 4/7] service cores: add unit tests
From: Jerin Jacob <hidden>
Date: 2017-07-11 08:12:32
-----Original Message-----
Date: Fri, 7 Jul 2017 17:41:04 +0100 From: Harry van Haaren <redacted> To: dev@dpdk.org CC: thomas@monjalon.net, jerin.jacob@caviumnetworks.com, keith.wiles@intel.com, bruce.richardson@intel.com, Harry van Haaren [off-list ref] Subject: [PATCH v4 4/7] service cores: add unit tests X-Mailer: git-send-email 2.7.4 Add a bunch of unit tests, to ensure that the service core functions are operating as expected. As part of these tests a dummy service is registered which allows identifying if a service callback has been invoked by using the CPU tick counter. This allows identifying if functions to start and stop service lcores are actually having effect. Signed-off-by: Harry van Haaren <redacted> --- v4: - Remove static slcore_id, make service-core choice dynamic (Jerin) - Use lcore_get_next() to acquire service cores (Jerin) - Improve unit test to ensure app can remote_launc() on a core that previously served as a service-core (verifies ROLE_RTE is set) (Jerin)
IMO, it has the unit testcases for every API now. Acked-by: Jerin Jacob <redacted>