Re: [RFC PATCH 1/1] virtio: write back features before verify
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2021-10-05 11:11:43
Also in:
linux-s390, lkml, qemu-devel
On Tue, Oct 05, 2021 at 12:46:34PM +0200, Halil Pasic wrote:
On Tue, 5 Oct 2021 03:53:17 -0400 "Michael S. Tsirkin" [off-list ref] wrote:quoted
quoted
Wouldn't a call from transport code into virtio core be more handy? What I have in mind is stuff like vhost-user and vdpa. My understanding is, that for vhost setups where the config is outside qemu, we probably need a new command that tells the vhost backend what endiannes to use for config. I don't think we can use VHOST_USER_SET_VRING_ENDIAN because that one is on a virtqueue basis according to the doc. So for vhost-user and similar we would fire that command and probably also set the filed, while for devices for which control plane is handled by QEMU we would just set the field. Does that sound about right?I'm fine either way, but when would you invoke this? With my idea backends can check the field when get_config is invoked. As for using this in VHOST, can we maybe re-use SET_FEATURES? Kind of hacky but nice in that it will actually make existing backends work...Basically the equivalent of this patch, just on the vhost interface, right? Could work I have to look into it :)
yep _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization