Re: [virtio-dev] Re: [RFC PATCH 1/1] virtio: write back features before verify
From: Cornelia Huck <cohuck@redhat.com>
Date: 2021-10-05 07:38:27
Also in:
linux-s390, lkml
On Mon, Oct 04 2021, "Michael S. Tsirkin" [off-list ref] wrote:
On Mon, Oct 04, 2021 at 05:45:06PM +0200, Cornelia Huck wrote:quoted
On Mon, Oct 04 2021, "Michael S. Tsirkin" [off-list ref] wrote:quoted
On Mon, Oct 04, 2021 at 04:27:23PM +0200, Cornelia Huck wrote:quoted
On Mon, Oct 04 2021, "Michael S. Tsirkin" [off-list ref] wrote:quoted
Do we want to also add explanation that features can be changed until FEATURES_OK?I always considered that to be implict, as feature negotiation is not over until we have FEATURES_OK. Not sure whether we need an extra note.Well Halil here says once you set a feature bit you can't clear it. So maybe not ...Ok, so what about something like "If FEATURES_OK is not set, the driver MAY change the set of features it accepts." in the device initialization section?Maybe "as long as". However Halil implied that some features are not turned off properly if that happens. Halil could you pls provide some examples?
Yes, "as long as" sounds better. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization