Subject: Re: [PATCH net v3 7/7] tipc: fix NULL pointer dereference in
named_distribute()
Thank you for your contribution! Sashiko AI review found 9 potential
issue(s) to consider.
Critical: 0 · High: 3 · Medium: 2 · Low: 4
If you believe none of the issues are legitimate, please reply to each issue of
Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply (one
such reply per series is enough).
- [High] tipc_nametb_insert_self_node_pub() (net/tipc/name_table.c)
corrupts nt->cluster_scope in its -EEXIST branch.
- [High] tipc_service_insert_publ() (net/tipc/name_table.c) erases and
kfree()s a service_range that still holds live publications whenever…
- [High] tipc: use-after-free of service_range on -EEXIST in
tipc_service_insert_publ()
- [Medium] tipc_node_write_unlock() (net/tipc/node.c) no longer resets
the link when the TIPC_LINK_STATE publication fails with -ENOBUFS.
- [Medium] On the deferred node-timer path, a failed bulk is never
retried when the peer has more than one link.
- [Low] The -EEXIST check in tipc_net_finalize() (net/tipc/net.c) is dead
code, because the caller and callee disagree on the contract.
- [Low] The commit message leaves out several behaviour changes and
slightly misdescribes how the publication reaches other nodes.
- [Low] The commit carries `Reported-by: kernel test robot
[off-list ref]` and `Closes: https://lore.kernel.org/oe-kbuild-…
- [Low] The kernel-doc for tipc_nametbl_insert() (net/tipc/name_table.c)
says it returns "Inserted publication - Success" and "-ENOBUFS - No…
I will address above feedbacks in the next version.
---
pw-bot: cr