RE: [PATCH net v3 6/7] tipc: fix self-deadlock in tipc_named_node_up

From
Tung Quang Nguyen <tung.quang.nguyen@est.tech>
Date
2026-11-18 02:24:56
Reply to
netdev-bot+sashiko@kernel.org, 2026-11-17
Subject: Re: [PATCH net v3 6/7] tipc: fix self-deadlock in tipc_named_node_up

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case you
want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] In net/tipc/node.c, the call to tipc_node_lxc_xmit() inside the
 new tipc_node_distribute() (line 1847) can never do anything, so it is…
- [Low] tipc_named_node_up() (net/tipc/name_distr.c, around lines
 227-231) maps -ELINKCONG to 0, with the comment "The link is congested…
I will address above feedback in the next version.

---
pw-bot: cr
Thread (18 messages) 18 messages, 2 authors, last reply 2h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help