RE: [PATCH net v3 4/7] tipc: fix missing link-up event on memory allocation failure

From
Tung Quang Nguyen <tung.quang.nguyen@est.tech>
Date
2026-11-18 02:18:57
Reply to
netdev-bot+sashiko@kernel.org, 2026-11-17
Subject: Re: [PATCH net v3 4/7] tipc: fix missing link-up event on memory
allocation failure

Thank you for your contribution! Sashiko AI review found 5 potential
issue(s) to consider.

Critical: 2 · High: 0 · Medium: 2 · Low: 1

If you believe none of the issues are legitimate, please reply to each issue of
Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply (one
such reply per series is enough).

- [Critical] The new duplicate (-EEXIST) error path in
 tipc_service_insert_publ() (net/tipc/name_table.c) erases and kfree()s…
- [Critical] The fault introduced by the -EEXIST free in
 tipc_service_insert_publ() leads to a remotely triggerable infinite…
- [Medium] In tipc_rcv() (net/tipc/node.c), the new code after
 tipc_node_write_unlock() takes the node read lock again and purges…
- [Medium] The commit message describes only plumbing an error code out
 of tipc_nametbl_publish() and resetting the link on -ENOBUFS.
- [Low] tipc_node_write_unlock() (net/tipc/node.c) reads bearer_id =
 n->link_id & 0xffff while holding n->lock, then calls…
I will address above feedbacks in the next version.

---
pw-bot: cr
Thread (18 messages) 18 messages, 2 authors, last reply 2h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help