Subject: Re: [PATCH net v3 5/7] tipc: validate original address of received skb in
tipc_named_rcv()
Thank you for your contribution! Sashiko AI review found 5 potential
issue(s) to consider.
Critical: 1 · High: 1 (1) · Medium: 2 · Low: 1
If you believe none of the issues are legitimate, please reply to each issue of
Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply (one
such reply per series is enough).
- [Critical] Both bug classes the commit says it fixes are still
reachable from a remote peer: publications that are never removed, and…
- [High] Check-then-act race in the new validation.
- [Medium] The fix for this case is right, but the commit message
describes the wrong mechanism and understates the impact.
- [Medium] The new check in tipc_named_rcv() only verifies that
msg_orignode(hdr) is some non-preliminary remote node in node_htable.
- [Low] The kernel-doc for the newly exported tipc_node_find_remote()
(node.c:660-669, prototype at node.h:106) does not describe the real…
I will address above feedback in the next version.
Pre-existing issues:
- [High] This problem wasn't introduced by this patch, but
tipc_publ_notify() walks n->publ_list with list_for_each_entry_safe()…
This needs separate series and should be addressed as follow-up.
---
pw-bot: cr