On Tue, Feb 03, 2026 at 12:49:57AM -0800, Ethan Nelson-Moore wrote:

On Tue, Feb 3, 2026 at 12:25 AM Andy Shevchenko
[off-list ref] wrote:

quoted

quoted

+extern int usbnet_mii_ioctl(struct net_device *net, struct ifreq *rq, int cmd);

Do we still need to populate 'extern'? Can we get rid of this redundancy?

In my opinion, while you're right that it isn't necessary because all
functions (unlike variables) are implied to be extern, the use of
extern to indicate functions that are exported/intended to be part of
the API is a good idea.

I'm not sure. This makes it harder to read for no benefit. All non-static
functions are part of the API.

-- 
With Best Regards,
Andy Shevchenko