Thread (6 messages) 6 messages, 3 authors, 2026-02-04

Re: [PATCH net-next v4] net: usb: introduce usbnet_mii_ioctl helper function

From: Ethan Nelson-Moore <hidden>
Date: 2026-02-03 08:50:08
Also in: linux-usb

Hi, Andy,

On Tue, Feb 3, 2026 at 12:25 AM Andy Shevchenko
[off-list ref] wrote:
quoted
+extern int usbnet_mii_ioctl(struct net_device *net, struct ifreq *rq, int cmd);
Do we still need to populate 'extern'? Can we get rid of this redundancy?
In my opinion, while you're right that it isn't necessary because all
functions (unlike variables) are implied to be extern, the use of
extern to indicate functions that are exported/intended to be part of
the API is a good idea.

Ethan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help