Re: [PATCH net-next v4] net: usb: introduce usbnet_mii_ioctl helper function
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2026-02-03 08:25:30
Also in:
linux-usb
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: 2026-02-03 08:25:30
Also in:
linux-usb
On Mon, Feb 02, 2026 at 05:34:55PM -0800, Ethan Nelson-Moore wrote:
Many USB network drivers use identical code to pass ioctl requests on to the MII layer. Reduce code duplication by refactoring this code into a helper function.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> ...
extern void usbnet_set_msglevel(struct net_device *, u32); extern void usbnet_set_rx_mode(struct net_device *net); extern void usbnet_get_drvinfo(struct net_device *, struct ethtool_drvinfo *); +extern int usbnet_mii_ioctl(struct net_device *net, struct ifreq *rq, int cmd);
Do we still need to populate 'extern'? Can we get rid of this redundancy?
extern int usbnet_nway_reset(struct net_device *net);
extern int usbnet_manage_power(struct usbnet *, int);
-- With Best Regards, Andy Shevchenko