Re: [PATCH 2/4] phy: s32g: Add serdes subsystem phy
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: 2026-01-29 13:36:19
Also in:
linux-arm-kernel, linux-devicetree, linux-phy, lkml
On Thu, 29 Jan 2026 at 14:23, Russell King (Oracle) [off-list ref] wrote:
On Thu, Jan 29, 2026 at 02:01:13PM +0100, Vincent Guittot wrote:quoted
yes, the usual pattern is : - phy_set_mode_ext() - then phy_power_on() but I can add an additional checkPlease read Documentation/driver-api/phy/phy.rst section "Order of API calls" which suggests phy_set_mode_ext() after phy_power_on().
Fair enough. That being said, all pcie drivers that use phy_set_mode_ext(), call it before phy_power_on()
Having different requirements for different SerDes PHYs quickly becomes annoying for users of the SerDes PHYs. E.g. I'm trying to add SerDes PHY support to stmmac, which is used across different platforms. Having all SerDes PHY drivers behave the same as far as their PHY API calls are concerned means that the whole point of having an abstracted interface is maintained. Otherwise, it's completely pointless. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!