Re: [PATCH 2/4] phy: s32g: Add serdes subsystem phy
From: Philipp Zabel <p.zabel@pengutronix.de>
Date: 2026-01-26 13:11:31
Also in:
linux-arm-kernel, linux-devicetree, linux-phy, lkml
On Mo, 2026-01-26 at 10:21 +0100, Vincent Guittot wrote:
s32g SoC family includes 2 serdes subsystems which are made of one PCIe controller, 2 XPCS and one Phy. The Phy got 2 lanes that can be configure to output PCIe lanes and/or SGMII. Implement PCIe phy support Co-developed-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@oss.nxp.com> Co-developed-by: Alexandru-Catalin Ionita <redacted> Signed-off-by: Alexandru-Catalin Ionita <redacted> Co-developed-by: Ghennadi Procopciuc <redacted> Signed-off-by: Ghennadi Procopciuc <redacted> Co-developed-by: Ionut Vicovan <redacted> Signed-off-by: Ionut Vicovan <redacted> Co-developed-by: Bogdan Roman <redacted> Signed-off-by: Bogdan Roman <redacted> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org> --- drivers/phy/freescale/Kconfig | 9 + drivers/phy/freescale/Makefile | 1 + drivers/phy/freescale/phy-nxp-s32g-serdes.c | 569 ++++++++++++++++++++ 3 files changed, 579 insertions(+) create mode 100644 drivers/phy/freescale/phy-nxp-s32g-serdes.c
[...]
quoted hunk ↗ jump to hunk
diff --git a/drivers/phy/freescale/phy-nxp-s32g-serdes.c b/drivers/phy/freescale/phy-nxp-s32g-serdes.c new file mode 100644 index 000000000000..8336c868c8dc --- /dev/null +++ b/drivers/phy/freescale/phy-nxp-s32g-serdes.c@@ -0,0 +1,569 @@
[...]
+static int s32g_serdes_get_ctrl_resources(struct platform_device *pdev, struct s32g_serdes *serdes)
+{[...]
+ ctrl->rst = devm_reset_control_get(dev, "serdes");
Please use devm_reset_control_get_exclusive() directly. [...]
+static int s32g_serdes_get_pcie_resources(struct platform_device *pdev, struct s32g_serdes *serdes)
+{[...]
+ pcie->rst = devm_reset_control_get(dev, "pcie");
Same here. regards Philipp