On Tue, Jan 27, 2026 at 10:53:04AM -0800, Jakub Kicinski wrote:

On Tue, 27 Jan 2026 18:06:49 +0000 Simon Horman wrote:

quoted

As per Jakub's advice in his review of v1 [*],
Please try to create a minimal driver in the order of ~5kLoC.

Perhaps other maintainers will disagree, but for ease of review
and to avoid the huge reposts perhaps we should consider merging
something like patches 1 and 3* first, as the initial series.
And then you can build up the driver from there in reasonable,
5kLoC-at-a-time series?

 * patch 3 currently includes things which do not seem machine
   generated / like register descriptors like structs added to
   nbl_def_channel.h and nbl_include.h

Without having looked into the details: yes, I think some
sort of staged approached could help here.