Thread (27 messages) 27 messages, 6 authors, 2026-01-28

Re: [PATCH v3 net-next 00/15] nbl driver for Nebulamatrix NICs

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2026-01-27 22:21:25
Also in: bpf, linux-doc, lkml

On Tue, 27 Jan 2026 10:53:04 -0800
Jakub Kicinski [off-list ref] wrote:
On Tue, 27 Jan 2026 18:06:49 +0000 Simon Horman wrote:
quoted
As per Jakub's advice in his review of v1 [*],
Please try to create a minimal driver in the order of ~5kLoC.  
Perhaps other maintainers will disagree, but for ease of review
and to avoid the huge reposts perhaps we should consider merging
something like patches 1 and 3* first, as the initial series.
And then you can build up the driver from there in reasonable,
5kLoC-at-a-time series?

 * patch 3 currently includes things which do not seem machine
   generated / like register descriptors like structs added to
   nbl_def_channel.h and nbl_include.h
Part of the size problem is that the driver has multiple layers:
resources, channels, etc and lots of code that tries to be common
across OS's. This can lead to bloat.  Very few drivers have done
that successfully. 
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help