+config NBL_CORE
+    tristate "Nebula-matrix Ethernet Controller m18100 Family support"
+    depends on 64BIT && PCI
+    default m
+    select PAGE_POOL
+    help
+      This driver supports Nebula-matrix Ethernet Controller m18100 Family of
+      devices.  For more information about this product, go to the product
+      description with smart NIC:

_CORE is a bit unusual for a driver. CORE is generally a library which
is shared by a number of drivers. It does not have a tristate string,
it is just selected by the drivers which need it.

+static int nbl_probe(struct pci_dev *pdev,
+		     const struct pci_device_id __always_unused *id)
+{
+	struct device *dev = &pdev->dev;
+
+	dev_dbg(dev, "nbl probe ok!\n");

Please don't have pointless debug messages. If your driver does not
even probe, you should not be submitting it.

+	return 0;
+}
+
+static void nbl_remove(struct pci_dev *pdev)
+{
+	dev_dbg(&pdev->dev, "nbl remove OK!\n");
+}
+
+#define NBL_VENDOR_ID			(0x1F0F)

    Andrew

---
pw-bot: cr