回复:[PATCH v3 net-next 00/15] nbl driver for Nebulamatrix NICs
From: Illusion Wang <hidden>
Date: 2026-01-28 02:47:01
Also in:
bpf, linux-doc, lkml
Thank you for your feedback patch3 primarily includes code that does not require extensive review, such as the message codes and message body structures defined in nbl_def_channel.h. These components are generally stable and used for PF/VF communication, which is why they were initially included in Patch 3. However, based on review feedback, I will extract these manually written communication protocol definitions. Additionally, I will make another round of comprehensive code reduction to meet the submission requirements as much as possible. ------------------------------------------------------------------ 发件人:Jakub Kicinski [off-list ref] 发送时间:2026年1月28日(周三) 02:53 收件人:Simon Horman[off-list ref]; Illusion Wang[off-list ref] 抄 送:Dimon[off-list ref]; Alvin[off-list ref]; Sam[off-list ref]; netdev[off-list ref]; "andrew+netdev"[off-list ref]; corbet[off-list ref]; "linux-doc"[off-list ref]; lorenzo[off-list ref]; pabeni[off-list ref]; "vadim.fedorenko"[off-list ref]; "lukas.bulwahn"[off-list ref]; hawk[off-list ref]; ast[off-list ref]; bpf[off-list ref]; sdf[off-list ref]; daniel[off-list ref]; "john.fastabend"[off-list ref]; edumazet[off-list ref]; open list[off-list ref] 主 题:Re: [PATCH v3 net-next 00/15] nbl driver for Nebulamatrix NICs On Tue, 27 Jan 2026 18:06:49 +0000 Simon Horman wrote:
As per Jakub's advice in his review of v1 [*], Please try to create a minimal driver in the order of ~5kLoC.
Perhaps other maintainers will disagree, but for ease of review and to avoid the huge reposts perhaps we should consider merging something like patches 1 and 3* first, as the initial series. And then you can build up the driver from there in reasonable, 5kLoC-at-a-time series? * patch 3 currently includes things which do not seem machine generated / like register descriptors like structs added to nbl_def_channel.h and nbl_include.h