On Thu, Jan 22, 2026 at 02:13:01PM +0200, Vladimir Oltean wrote:

On Thu, Jan 22, 2026 at 02:06:23PM +0200, Andy Shevchenko wrote:

quoted

quoted

Cc: Mark Brown <broonie@kernel.org>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>

FWIW, Cc list may be located after --- line. It will have the same effect on
emails (as regular tooling will parse and put them into email headers), but
will reduce unneeded noise in the commit message. List will be still available
on lore.kernel.org in the mail archives.

Thanks for the comment. I know it may be located after ---, but for me,
doing that implies an extra step which I find unnecessary (moving them
there after the git format-patch stage). I keep the Cc: in the commit
message in git so that it's preserved across revisions.

You can keep them in your commit message. Many --- lines are also allowed!

quoted

quoted

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---

  Cc: ...
  ...

...

quoted

quoted

+	unsigned int base;

Hmm... resource_size_t ?

Well, regmap_read() takes "unsigned int reg".
https://elixir.bootlin.com/linux/v6.18.6/source/include/linux/regmap.h#L1297
So in practice, a truncation will be done somewhere if the register base
exceeds unsigned int storage capacity. But I didn't feel that it's worth
handling that.

Maybe a comment near to the assignment?

-- 
With Best Regards,
Andy Shevchenko