Re: [PATCH v2 net-next 01/15] net: mdio-regmap: permit working with non-MMIO regmaps
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2026-01-22 12:13:07
Also in:
linux-devicetree, lkml
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2026-01-22 12:13:07
Also in:
linux-devicetree, lkml
On Thu, Jan 22, 2026 at 02:06:23PM +0200, Andy Shevchenko wrote:
quoted
Cc: Mark Brown <broonie@kernel.org> Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>FWIW, Cc list may be located after --- line. It will have the same effect on emails (as regular tooling will parse and put them into email headers), but will reduce unneeded noise in the commit message. List will be still available on lore.kernel.org in the mail archives.
Thanks for the comment. I know it may be located after ---, but for me, doing that implies an extra step which I find unnecessary (moving them there after the git format-patch stage). I keep the Cc: in the commit message in git so that it's preserved across revisions.
quoted
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com> ---Cc: ... ... ...quoted
struct mdio_regmap_priv { struct regmap *regmap; + unsigned int base;Hmm... resource_size_t ?
Well, regmap_read() takes "unsigned int reg". https://elixir.bootlin.com/linux/v6.18.6/source/include/linux/regmap.h#L1297 So in practice, a truncation will be done somewhere if the register base exceeds unsigned int storage capacity. But I didn't feel that it's worth handling that.
quoted
u8 valid_addr; };-- With Best Regards, Andy Shevchenko