[PATCH v2 net-next 13/15] net: dsa: sja1105: permit finding the XPCS via pcs-handle
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Date: 2026-01-22 10:57:40
Also in:
linux-devicetree, lkml
Subsystem:
networking drivers, networking [dsa], the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Vladimir Oltean, Linus Torvalds
This completes support for describing the XPCS in the device tree, rather than just the case where sja1105_fill_device_tree() populates it. Having it in the device tree is necessary when configuring lane polarity. Note: I would have added a pcs-handle during sja1105_fill_device_tree() too (for more unified handling), but this doesn't seem to be supported with the of_changeset API. Cc: Rob Herring <robh@kernel.org> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Conor Dooley <conor+dt@kernel.org> Cc: devicetree@vger.kernel.org Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- v1->v2: rewrite commit message drivers/net/dsa/sja1105/sja1105_main.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c
index b60a890ba416..3c2030e8fce5 100644
--- a/drivers/net/dsa/sja1105/sja1105_main.c
+++ b/drivers/net/dsa/sja1105/sja1105_main.c@@ -3008,14 +3008,26 @@ static int sja1105_port_bridge_flags(struct dsa_switch *ds, int port, static int sja1105_create_pcs(struct dsa_switch *ds, int port) { + struct dsa_port *dp = dsa_to_port(ds, port); struct sja1105_private *priv = ds->priv; + struct fwnode_handle *pcs_fwnode; struct phylink_pcs *pcs; if (priv->phy_mode[port] != PHY_INTERFACE_MODE_SGMII && priv->phy_mode[port] != PHY_INTERFACE_MODE_2500BASEX) return 0; - pcs = xpcs_create_pcs_fwnode(priv->pcs_fwnode[port]); + pcs_fwnode = fwnode_handle_get(priv->pcs_fwnode[port]); + /* priv->pcs_fwnode[port] is only set if the PCS is absent + * from the device tree source. If present, there needs to + * be a pcs-handle to it. + */ + if (!pcs_fwnode) + pcs_fwnode = fwnode_find_reference(of_fwnode_handle(dp->dn), + "pcs-handle", 0); + + pcs = xpcs_create_pcs_fwnode(pcs_fwnode); + fwnode_handle_put(pcs_fwnode); if (IS_ERR(pcs)) return PTR_ERR(pcs);
--
2.34.1