On Thu, Jan 22, 2026 at 12:56:43PM +0200, Vladimir Oltean wrote:
Prepare a single regmap covering the entire SPI address space of the
SJA1105 and SJA1110 switches which can be given to MDIO buses, XPCS,
irqchip drivers etc.
This regmap is address-zero-based (can access the entire switch address
space) and child devices are supposed to access their respective memory
region with the help of struct resource (IORESOURCE_REG, to be precise).
Nothing is currently done with the regmap, it is just allocated and
added to the device's devres list, so it doesn't need to be freed.
...
quoted hunk ↗ jump to hunk
--- a/drivers/net/dsa/sja1105/sja1105.h
+++ b/drivers/net/dsa/sja1105/sja1105.h
quoted hunk ↗ jump to hunk
#include <linux/dsa/8021q.h>
#include <net/dsa.h>
#include <linux/mutex.h>
+#include <linux/regmap.h>
+
#include "sja1105_static_config.h"
It looks to me that somebody missed grouping above (not this change) and it's
better to have it done:
#include <linux/dsa/8021q.h>
#include <linux/mutex.h>
#include <linux/regmap.h>
#include <net/dsa.h>
#include "sja1105_static_config.h"
...
quoted hunk ↗ jump to hunk
+ rc = devm_sja1105_create_regmap(priv);
+ if (rc < 0) {
+ dev_err(dev, "Failed to create regmap: %pe\n", ERR_PTR(rc));
+ return rc;
+ }
Hmm... Perhaps return dev_err_probe(...); ?
--
With Best Regards,
Andy Shevchenko