Re: [PATCH v2 15/15] gpio: virtio: reorder fields to reduce struct padding
From: Bartosz Golaszewski <brgl@kernel.org>
Date: 2026-01-05 09:49:10
Also in:
kvm, linux-crypto, linux-doc, linux-gpio, linux-iommu, linux-scsi, lkml, virtualization
On Mon, 5 Jan 2026 09:23:49 +0100, "Michael S. Tsirkin" [off-list ref] said:
quoted hunk ↗ jump to hunk
Reorder struct virtio_gpio_line fields to place the DMA buffers (req/res) last. This eliminates the padding from aligning struct size on ARCH_DMA_MINALIGN. Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/gpio/gpio-virtio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/gpio/gpio-virtio.c b/drivers/gpio/gpio-virtio.c index b70294626770..ed6e0e90fa8a 100644 --- a/drivers/gpio/gpio-virtio.c +++ b/drivers/gpio/gpio-virtio.c@@ -26,11 +26,12 @@ struct virtio_gpio_line { struct mutex lock; /* Protects line operation */ struct completion completion; + unsigned int rxlen; + __dma_from_device_group_begin(); struct virtio_gpio_request req; struct virtio_gpio_response res; __dma_from_device_group_end(); - unsigned int rxlen; }; struct vgpio_irq_line { --MST
Acked-by: Bartosz Golaszewski <redacted>