Re: [PATCH v7 01/14] dt-bindings: net: mediatek,net: allow irq names
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-07-01 06:44:06
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, linux-pm, lkml
On Sat, Jun 28, 2025 at 06:54:36PM +0200, Frank Wunderlich wrote:
From: Frank Wunderlich <redacted> In preparation for MT7988 and RSS/LRO allow the interrupt-names
Why? What preparation, what is the purpose of adding the names, what do they solve?
property. Also increase the maximum IRQ count to 8 (4 FE + 4 RSS),
Why? There is no user of 8 items.
but set boundaries for all compatibles same as irq count.
Your patch does not do it.
quoted hunk ↗ jump to hunk
Signed-off-by: Frank Wunderlich <redacted> --- v7: fixed wrong rebase v6: new patch splitted from the mt7988 changes --- .../devicetree/bindings/net/mediatek,net.yaml | 38 ++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-)diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml index 9e02fd80af83..6672db206b38 100644 --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml@@ -40,7 +40,19 @@ properties: interrupts: minItems: 1 - maxItems: 4 + maxItems: 8 + + interrupt-names: + minItems: 1 + items: + - const: fe0 + - const: fe1 + - const: fe2 + - const: fe3 + - const: pdma0 + - const: pdma1 + - const: pdma2 + - const: pdma3 power-domains: maxItems: 1@@ -135,6 +147,10 @@ allOf: minItems: 3 maxItems: 3 + interrupt-names: + minItems: 3 + maxItems: 3 + clocks: minItems: 4 maxItems: 4@@ -166,6 +182,9 @@ allOf: interrupts: maxItems: 1 + interrupt-namess: + maxItems: 1 + clocks: minItems: 2 maxItems: 2@@ -192,6 +211,10 @@ allOf: minItems: 3 maxItems: 3 + interrupt-names: + minItems: 3 + maxItems: 3 + clocks: minItems: 11 maxItems: 11@@ -232,6 +255,10 @@ allOf: minItems: 3 maxItems: 3 + interrupt-names: + minItems: 3 + maxItems: 3 + clocks: minItems: 17 maxItems: 17@@ -274,6 +301,9 @@ allOf: interrupts: minItems: 4 + interrupt-names: + minItems: 4 + clocks: minItems: 15 maxItems: 15@@ -312,6 +342,9 @@ allOf: interrupts: minItems: 4 + interrupt-names: + minItems: 4
8 interrupts is now valid?
quoted hunk ↗ jump to hunk
+ clocks: minItems: 15 maxItems: 15@@ -350,6 +383,9 @@ allOf: interrupts: minItems: 4 + interrupt-names: + minItems: 4
So why sudenly this device gets 8 interrupts? This makes no sense, nothing explained in the commit msg. I understand nothing from this patch and I already asked you to clearly explain why you are doing things. This patch on its own makes no sense. Best regards, Krzysztof