Re: [PATCH v7 02/14] dt-bindings: net: mediatek,net: update for mt7988
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2025-07-01 06:41:46
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, linux-pm, lkml
On Sat, Jun 28, 2025 at 06:54:37PM +0200, Frank Wunderlich wrote:
From: Frank Wunderlich <redacted> Update binding for mt7988 which has 3 gmac and a sram for dma operations.
I asked why you are updating. You claim you update because it has 3 GMAC... but that's irrelevant, because it is easy to answer with: it did not have 3 GMAC before? So same question: Provide real reason why you are making updates. That's why you have commit msg.
MT7988 has 4 FE IRQs (currently only 2 are used) and 4 IRQs for use
mt7988 or MT7988? gmac or GMAC? SRAM or SRAM? and so on... it is not easy to read and understand your commit msgs.
quoted hunk ↗ jump to hunk
with RSS/LRO later. Signed-off-by: Frank Wunderlich <redacted> --- v6: - split out the interrupt-names into separate patch - update irq(name) min count to 4 - add sram-property - drop second reg entry and minitems as there is only 1 item left again v5: - fix v4 logmessage and change description a bit describing how i get the irq count. - update binding for 8 irqs with different names (rx,tx => fe0..fe3) including the 2 reserved irqs which can be used later - change rx-ringX to pdmaX to be closer to hardware documentation v4: - increase max interrupts to 6 because of adding RSS/LRO interrupts (4) and dropping 2 reserved irqs (0+3) around rx+tx - dropped Robs RB due to this change - allow interrupt names - add interrupt-names without reserved IRQs on mt7988 this requires mtk driver patch: https://patchwork.kernel.org/project/netdevbpf/patch/20250616080738.117993-2-linux@fw-web.de/ v2: - change reg to list of items --- Documentation/devicetree/bindings/net/mediatek,net.yaml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)diff --git a/Documentation/devicetree/bindings/net/mediatek,net.yaml b/Documentation/devicetree/bindings/net/mediatek,net.yaml index 6672db206b38..74a139000f60 100644 --- a/Documentation/devicetree/bindings/net/mediatek,net.yaml +++ b/Documentation/devicetree/bindings/net/mediatek,net.yaml@@ -28,7 +28,8 @@ properties: - ralink,rt5350-eth reg: - maxItems: 1 + items: + - description: Register for accessing the MACs.
Why making this change? It's redundant and nothing in commit msg explains that. Best regards, Krzysztof