Re: [PATCH v7 07/14] arm64: dts: mediatek: mt7988: add basic ethernet-nodes
From: Daniel Golle <daniel@makrotopia.org>
Date: 2025-06-29 14:47:12
Also in:
linux-arm-kernel, linux-devicetree, linux-mediatek, linux-pm, lkml
On Sat, Jun 28, 2025 at 06:54:42PM +0200, Frank Wunderlich wrote:
quoted hunk ↗ jump to hunk
From: Frank Wunderlich <redacted> Add basic ethernet related nodes. Mac1+2 needs pcs (sgmii+usxgmii) to work correctly which will be linked later when driver is merged. Signed-off-by: Daniel Golle <daniel@makrotopia.org> Signed-off-by: Frank Wunderlich <redacted> --- v6: - fix whitespace-errors for pdma irqs (spaces vs. tabs) - move sram from eth reg to own sram node (needs CONFIG_SRAM) v5: - add reserved irqs and change names to fe0..fe3 - change rx-ringX to pdmaX to be closer to documentation v4: - comment for fixed-link on gmac0 - update 2g5 phy node - unit-name dec instead of hex to match reg property - move compatible before reg - drop phy-mode - add interrupts for RSS - add interrupt-names and drop reserved irqs for ethernet - some reordering - eth-reg and clock whitespace-fix based on angelos review --- arch/arm64/boot/dts/mediatek/mt7988a.dtsi | 137 +++++++++++++++++++++- 1 file changed, 134 insertions(+), 3 deletions(-)diff --git a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi index 560ec86dbec0..cf765a6b1fa8 100644 --- a/arch/arm64/boot/dts/mediatek/mt7988a.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7988a.dtsi@@ -680,7 +680,28 @@ xphyu3port0: usb-phy@11e13000 { }; }; - clock-controller@11f40000 { + xfi_tphy0: phy@11f20000 { + compatible = "mediatek,mt7988-xfi-tphy"; + reg = <0 0x11f20000 0 0x10000>; + clocks = <&xfi_pll CLK_XFIPLL_PLL_EN>, + <&topckgen CLK_TOP_XFI_PHY_0_XTAL_SEL>; + clock-names = "xfipll", "topxtal"; + resets = <&watchdog 14>; + mediatek,usxgmii-performance-errata; + #phy-cells = <0>; + }; + + xfi_tphy1: phy@11f30000 { + compatible = "mediatek,mt7988-xfi-tphy"; + reg = <0 0x11f30000 0 0x10000>; + clocks = <&xfi_pll CLK_XFIPLL_PLL_EN>, + <&topckgen CLK_TOP_XFI_PHY_1_XTAL_SEL>; + clock-names = "xfipll", "topxtal"; + resets = <&watchdog 15>; + #phy-cells = <0>; + }; + + xfi_pll: clock-controller@11f40000 { compatible = "mediatek,mt7988-xfi-pll"; reg = <0 0x11f40000 0 0x1000>; resets = <&watchdog 16>;@@ -714,19 +735,129 @@ phy_calibration_p3: calib@97c { }; }; - clock-controller@15000000 { + ethsys: clock-controller@15000000 { compatible = "mediatek,mt7988-ethsys", "syscon"; reg = <0 0x15000000 0 0x1000>; #clock-cells = <1>; #reset-cells = <1>; }; - clock-controller@15031000 { + ethwarp: clock-controller@15031000 { compatible = "mediatek,mt7988-ethwarp"; reg = <0 0x15031000 0 0x1000>; #clock-cells = <1>; #reset-cells = <1>; }; + + eth: ethernet@15100000 { + compatible = "mediatek,mt7988-eth"; + reg = <0 0x15100000 0 0x80000>;
I think this should be reg = <0 0x15100000 0 0x40000>; as the range from 15140000 ~ 1517ffff is used as SRAM on MT7981/MT7986 and doesn't seem to be used at all on MT7988. root@OpenWrt:~# devmem 0x15140000 32 0xDEADBEEF ... root@OpenWrt:~# devmem 0x1517fffc 32 0xDEADBEEF (with 0xDEADBEEF all that range)