Hello Geert,

Thanks for your review.

-----Original Message-----
From: Geert Uytterhoeven <geert@linux-m68k.org>
Sent: Tuesday, June 17, 2025 5:51 PM
To: John Madieu <john.madieu.xa@bp.renesas.com>
Subject: Re: [PATCH v2 3/3] arm64: dts: renesas: rzg3e-smarc-som: Enable
eth{0-1} (GBETH) interfaces

Hi John,

On Wed, 11 Jun 2025 at 11:00, John Madieu [off-list ref]
wrote:

quoted

Enable the Gigabit Ethernet Interfaces (GBETH) populated on the RZ/G3E
SMARC EVK

Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Tested-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>

Thanks for your patch!

quoted

--- a/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzg3e-smarc-som.dtsi

quoted

@@ -77,6 +79,74 @@ &audio_extal_clk {
        clock-frequency = <48000000>;
 };

+&eth0 {
+       phy-handle = <&phy0>;
+       phy-mode = "rgmii-id";
+
+       pinctrl-0 = <&eth0_pins>;
+       pinctrl-names = "default";
+       status = "okay";
+
+       mdio {

&mdio0 {

quoted

+               #address-cells = <1>;
+               #size-cells = <0>;
+               compatible = "snps,dwmac-mdio";

No need for these three properties, as they are already present in the
SoC-specific DTS with the exact same values.

Same for the second interface.

Noted. Will handle that in the v3.

The rest LGTM, so with the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

Regards,

John

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
m68k.org

In personal conversations with technical people, I call myself a hacker.
But when I'm talking to journalists I just say "programmer" or something
like that.
                                -- Linus Torvalds