Re: [PATCH v2 2/3] arm64: dts: renesas: r9a09g047: Add GBETH nodes
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2025-06-17 15:32:29
Also in:
linux-devicetree, linux-renesas-soc, lkml
Hi John, On Wed, 11 Jun 2025 at 11:01, John Madieu [off-list ref] wrote:
Add GBETH nodes to RZ/G3E (R9A09G047) SoC DTSI. Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com> Tested-by: Biju Das <biju.das.jz@bp.renesas.com> Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
Thanks for your patch!
quoted hunk ↗ jump to hunk
--- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi@@ -759,6 +759,213 @@ csi2cru: endpoint@0 { }; }; }; + + eth0: ethernet@15c30000 {
[...]
+ mdio {You probably want to add a label (mdio0) here...
+ compatible = "snps,dwmac-mdio"; + #address-cells = <1>; + #size-cells = <0>; + };
+ eth1: ethernet@15c40000 {[...]
+ mdio {... and here (mdio1), for easier configuration of the PHY in the board-specific DTS.
+ compatible = "snps,dwmac-mdio"; + #address-cells = <1>; + #size-cells = <0>; + };
The rest LGTM, so
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds