回覆: [net-next 2/4] ARM: dts: ast2600-evb: add default RGMII delay

From
Jacky Chou <jacky_chou@aspeedtech.com>
Date
2025-03-18 11:00:31
Also in
linux-aspeed, linux-devicetree, lkml
Reply to
Andrew Lunn, 2025-03-17
Hi Andrew,

Thank you for your reply.
quoted
 	phy-mode = "rgmii";
 	phy-handle = <&ethphy2>;

+	tx-internal-delay-ps = <8>;
+	rx-internal-delay-ps = <4>;
+
Ideally you want:

	phy-mode = "rgmii-id";
	tx-internal-delay-ps = <0>;
	rx-internal-delay-ps = <0>;

Since 'rgmii-id' correctly describes the hardware.
I still confuse about ethernet-controller.yaml.
It lists 'rgmi', 'rgmii-rxid', 'rgmii-txid' and 'rgmii-id'.

ethernet-controller.yaml
...
      # RX and TX delays are added by the MAC when required
      - rgmii

      # RGMII with internal RX and TX delays provided by the PHY,
      # the MAC should not add the RX or TX delays in this case
      - rgmii-id

      # RGMII with internal RX delay provided by the PHY, the MAC
      # should not add an RX delay in this case
      - rgmii-rxid

      # RGMII with internal TX delay provided by the PHY, the MAC
      # should not add an TX delay in this case
      - rgmii-txid
...

It seems if MAC has ability to add delay in MAC internal, driver can use these
values to describes the hardware design.

I know this topic had been discussed. I thought for a while to find a solution, but I 
cannot still understand why 'rgmii-id' is correct for HW?

Thanks,
Jacky
Thread (28 messages) 28 messages, 6 authors, last reply 2025-03-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help