Re: [net-next 3/4] dt-bindings: net: ftgmac100: add rgmii delay properties

From
Krzysztof Kozlowski <krzk@kernel.org>
Date
2025-03-17 07:32:28
Also in
linux-arm-kernel, linux-aspeed, linux-devicetree, lkml
Reply to
Jacky Chou, 2025-03-17
On 17/03/2025 03:59, Jacky Chou wrote:
Add tx-internal-delay-ps and rx-internal-delay-ps to
Please wrap code according to the preferred limit expressed in Kernel
coding style (checkpatch is not a coding style description, but only a
tool).  However don't wrap blindly (see Kernel coding style).
configure the RGMII delay for MAC. According to
ethernet-controller.yaml, they use for RGMII TX and RX delay.

In Aspeed desgin, the RGMII delay is a number of ps as unit to
set delay, do not use one ps as unit. The values are different
from each MAC. So, here describes the property values
as index to configure corresponding scu register.

Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
...
quoted hunk ↗ jump to hunk
   mdio:
     $ref: /schemas/net/mdio.yaml#
 
@@ -102,4 +116,4 @@ examples:
                 reg = <1>;
             };
         };
-    };
+    };
\ No newline at end of file

This was neither tested nor reviewed by you before sending.


Best regards,
Krzysztof
Thread (28 messages) 28 messages, 6 authors, last reply 2025-03-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help