Thread (54 messages) 54 messages, 10 authors, 2025-03-02

Re: [PATCH 02/17] bitops: Add generic parity calculation for u64

From: Yury Norov <yury.norov@gmail.com>
Date: 2025-03-02 15:47:45
Also in: bpf, dri-devel, linux-input, linux-media, linux-serial, linux-wireless, lkml

On Thu, Feb 27, 2025 at 09:57:41PM +0000, David Laight wrote:
quoted
It's still unclear to me that this parity thing is used in hot paths.
If that holds, it's unclear that your hand-made version is better than
what's generated by GCC.
I wasn't seriously considering doing that optimisation.
Perhaps just hoping is might make a compiler person think :-)
David, can you suggest only things you're seriously considered to do?
Random suggestions distract my contributors and make them doing unneeded
work and experiments.

In the other thread you asked I Hsin to try your approach to GENMASK()
macro, saying you're lazy. I don't think this is the right way to
communicate, not mentioning that if you're lazy to try your own
approach, it doesn't sound nice to ask someone else to try it.

Thanks for understanding,
Yury
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help