Re: [PATCH net-next] net: ethtool: Don't check if RSS context exists in case of context 0

From
Jakub Kicinski <kuba@kernel.org>
Date
2025-03-03 22:17:18
Reply to
Gal Pressman, 2025-03-02
On Sun, 2 Mar 2025 11:55:34 +0200 Gal Pressman wrote:
quoted
quoted
I can think of something like redirecting all TCP traffic to context 1,
and then a specific TCP 5-tuple to the default context.  
The ordering guarantees of ntuple filters are a bit unclear.
My understanding was that first match terminates the search,
actually, so your example wouldn't work :S  
The ordering should be done according to the rule location.
 * @location: Location of rule in the table.  Locations must be
 *	numbered such that a flow matching multiple rules will be
 *	classified according to the first (lowest numbered) rule.
I'm aware, Gal, but the question is whether every driver developer 
is aware of this, not just me and perhaps you.
The cited patch is a regression from user's perspective. Surely, not an
intended one?
I believe this message should already answer you questions:
https://lore.kernel.org/all/20250226204503.77010912@kernel.org/ (local)
Fix the commit message, add test, repost.
Thread (16 messages) 16 messages, 4 authors, last reply 2025-03-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help