Re: [PATCH net-next] net: ethtool: Don't check if RSS context exists in case of context 0

From
Edward Cree <ecree.xilinx@gmail.com>
Date
2025-02-27 15:18:50
Reply to
Jakub Kicinski, 2025-02-27
On 27/02/2025 04:45, Jakub Kicinski wrote:
The ordering guarantees of ntuple filters are a bit unclear.
My understanding was that first match terminates the search,
actually, so your example wouldn't work :S
My understanding is that in most ntuple implementations more-
 specific filters override less-specific ones, in which case
 Gal's setup would work.
On other implementations which use the rule number as a
 position (like the API/naming implies) you could insert the
 5-tuple rule first and that would work too.
Oh, I think Ed may tell us that using context 0 + queue offset is legit.
I hadn't actually thought of that, but yes that's true too.

Anyway, 'mechanism, not policy' says we should allow ctx 0
 unless there's some mechanism reason why it can't be
 supported, and I don't see one.
Thread (16 messages) 16 messages, 4 authors, last reply 2025-03-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help