Re: [PATCH net-next] net: ethtool: Don't check if RSS context exists in case of context 0

From
Jakub Kicinski <kuba@kernel.org>
Date
2025-02-27 04:45:04
Reply to
Jakub Kicinski, 2025-02-27
On Wed, 26 Feb 2025 18:27:17 -0800 Jakub Kicinski wrote:
quoted
Anyway, it used to work.  
To be clear unit tests don't count as "breaking real users",
and I assume the complaint comes from your QA team?

Given the weak definition of the ntuple API I'd prefer to
close this corner case. Unless someone feels strongly that
this should be allowed. If a real user complains we can both
fix and try to encode their flow into a selftest.

Let me CC Ed, too.
Oh, I think Ed may tell us that using context 0 + queue offset is legit.
If he does, please respin with that as the justification and the test
case as suggested by Joe.
-- 
pw-bot: cr
Thread (16 messages) 16 messages, 4 authors, last reply 2025-03-04
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help