Thread (18 messages) 18 messages, 5 authors, 2025-02-20

Re: [PATCH net-next 2/2] net: mctp: Add MCTP USB transport driver

From: Jeremy Kerr <jk@codeconstruct.com.au>
Date: 2025-02-10 01:57:24
Also in: linux-usb

Hi Horms,
quoted
+               skb->protocol = htons(ETH_P_MCTP);
+               skb_reset_network_header(skb);
+               cb = __mctp_cb(skb);
+               cb->halen = 0;
+               netif_rx(skb);
Hi Jeremy,

skb is dereferenced a few lines further down,
but I don't think it is is safe to do so after calling netif_rx().
Yep, neither do I. I have moved the rx accounting prior to the
netif_rx() call for v2.

Thanks for the check!

Cheers,


Jeremy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help