Hi Greg,

Thanks for the review.

quoted

--- /dev/null
+++ b/include/linux/usb/mctp-usb.h

@@ -0,0 +1,28 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * mctp-usb.h - MCTP USB transport binding: common definitions.
+ *
+ * These are protocol-level definitions, that may be shared between host
+ * and gadget drivers.

Perhaps add a link to the spec?

Can do. I have one in the actual driver, but can replicate that here if
it's helpful.

quoted

+ *
+ * Copyright (C) 2024 Code Construct Pty Ltd

It's 2025 now :)

WHAT?!

:D

(this was started in 2024, and I have some preliminary versions up since
then, but I assume the last date is preferrable)

Unless I hear otherwise, I'll v2 this after a netdev-appropriate
backoff, with the added link and 2025 for both patches.

Cheers,


Jeremy