On Fri, Feb 07, 2025 at 04:49:05PM +0800, Jeremy Kerr wrote:

Hi Greg,

Just a check here:

quoted

quoted

+               dev_err(&mctp_usb->usbdev->dev, "%s: urb status: %d\n",
+                       __func__, status);

This could flood the logs, are you sure you need it at dev_err()
level?

And __func__ is redundant, it's present in dev_*() calls already.

am I missing something then?

   [  146.130170] usb 2-1: short packet (hdr) 6

emitted from:

    dev_dbg(&mctp_usb->usbdev->dev,
            "short packet (hdr) %d\n",
            hdr->len);

Seems like we get the driver name, but not the function.

I'm happy to remove the __func__ output either way, but I will also
make the logs a little more descriptive for context, if we don't have
func data.

Please read Documentation/admin-guide/dynamic-debug-howto.rst, it shows
how to get the function information from the dev_dbg() lines at runtime.

In short:
	$ alias ddcmd='echo $* > /proc/dynamic_debug/control'
	# add function to all enabled messages
	$ ddcmd '+f'

hope this helps,

greg k-h