-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: 28 January 2025 19:45
To: Swathi K S <redacted>; robh@kernel.org;
davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
pabeni@redhat.com; conor+dt@kernel.org; richardcochran@gmail.com;
mcoquelin.stm32@gmail.com; andrew@lunn.ch; alim.akhtar@samsung.com;
linux-fsd@tesla.com
Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-
kernel@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
alexandre.torgue@foss.st.com; peppe.cavallaro@st.com;
joabreu@synopsys.com; rcsekar@samsung.com; ssiddha@tesla.com;
jayati.sahu@samsung.com; pankaj.dubey@samsung.com;
ravi.patel@samsung.com; gost.dev@samsung.com
Subject: Re: [PATCH v5 1/4] dt-bindings: net: Add FSD EQoS device tree
bindings

On 28/01/2025 11:25, Swathi K S wrote:

quoted

+  Tesla ethernet devices based on dwmmac support Gigabit ethernet.
+
+allOf:
+  - $ref: snps,dwmac.yaml#
+
+properties:
+  compatible:
+    const: tesla,fsd-ethqos.yaml
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    minItems: 5
+    maxItems: 10

Why is this flexible?

Anyway, you need to list and describe the items instead of min/maxItems.

quoted

+
+  clock-names:
+    minItems: 5
+    maxItems: 10

Same here.

quoted

+
+  iommus:
+    maxItems: 1
+
+  phy-mode:
+    enum:
+     - rgmii-id
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - iommus
+  - phy-mode
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/fsd-clk.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+    ethernet_1: ethernet@14300000 {

Please implement last comment from Rob.

This label is used to enable the node in dts. Could see similar labels in other yaml files. Am I missing something here?

quoted

+              compatible = "tesla,fsd-ethqos";
+              reg = <0x0 0x14300000 0x0 0x10000>;

And since there is going to be new version, switch to the preferred
indentation (4-space). Other option is 2 spaces, but not 8.

quoted

+...

Best regards,
Krzysztof