RE: [PATCH v5 2/4] net: stmmac: dwc-qos: Add FSD EQoS support
From: Swathi K S <hidden>
Date: 2025-01-29 11:15:25
Also in:
linux-arm-kernel, linux-devicetree, linux-samsung-soc, lkml
From: Swathi K S <hidden>
Date: 2025-01-29 11:15:25
Also in:
linux-arm-kernel, linux-devicetree, linux-samsung-soc, lkml
-----Original Message----- From: Russell King (Oracle) <linux@armlinux.org.uk> Sent: 28 January 2025 20:30 To: Swathi K S <redacted> Cc: krzk@kernel.org; robh@kernel.org; davem@davemloft.net; edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; conor+dt@kernel.org; richardcochran@gmail.com; mcoquelin.stm32@gmail.com; andrew@lunn.ch; alim.akhtar@samsung.com; linux-fsd@tesla.com; netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org; alexandre.torgue@foss.st.com; peppe.cavallaro@st.com; joabreu@synopsys.com; rcsekar@samsung.com; ssiddha@tesla.com; jayati.sahu@samsung.com; pankaj.dubey@samsung.com; ravi.patel@samsung.com; gost.dev@samsung.com Subject: Re: [PATCH v5 2/4] net: stmmac: dwc-qos: Add FSD EQoS support On Tue, Jan 28, 2025 at 03:55:56PM +0530, Swathi K S wrote:quoted
+struct fsd_eqos_plat_data { + struct clk_bulk_data *clks; + int num_clks; + struct device *dev;You only write to this, so it serves no purpose in this patch. Please
remove. Hi Russell, Thanks for reviewing. Will remove struct device *dev from struct fsd_eqos_plat_data -Swathi
Thanks. -- RMK's Patch system: https://protect2.fireeye.com/v1/url?k=8378c0b8- e2f3d582-83794bf7-74fe4860008a-3788c416dc857e61&q=1&e=4d22ed29- 449b-46e6-90ba- 9b1470e01ecb&u=https%3A%2F%2Fwww.armlinux.org.uk%2Fdeveloper%2F patches%2F FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!