Thread (21 messages) 21 messages, 5 authors, 2025-02-04

RE: [PATCH v5 4/4] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC

From: Swathi K S <hidden>
Date: 2025-01-29 11:15:27
Also in: linux-arm-kernel, linux-devicetree, linux-samsung-soc, lkml

-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: 28 January 2025 19:48
To: Swathi K S <redacted>; robh@kernel.org;
davem@davemloft.net; edumazet@google.com; kuba@kernel.org;
pabeni@redhat.com; conor+dt@kernel.org; richardcochran@gmail.com;
mcoquelin.stm32@gmail.com; andrew@lunn.ch; alim.akhtar@samsung.com;
linux-fsd@tesla.com
Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-
kernel@vger.kernel.org; linux-stm32@st-md-mailman.stormreply.com;
linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
alexandre.torgue@foss.st.com; peppe.cavallaro@st.com;
joabreu@synopsys.com; rcsekar@samsung.com; ssiddha@tesla.com;
jayati.sahu@samsung.com; pankaj.dubey@samsung.com;
ravi.patel@samsung.com; gost.dev@samsung.com
Subject: Re: [PATCH v5 4/4] arm64: dts: fsd: Add Ethernet support for PERIC
Block of FSD SoC

On 28/01/2025 11:25, Swathi K S wrote:
quoted
 &pinctrl_pmu {
diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
b/arch/arm64/boot/dts/tesla/fsd.dtsi
quoted
index cc67930ebf78..670f6a852542 100644
--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
@@ -1027,6 +1027,33 @@
 			phy-mode = "rgmii-id";
 			status = "disabled";
 		};
+
+		ethernet_1: ethernet@14300000 {
Don't add nodes to the end, because that lead to mess we have there.
Squeeze it somewhere where impact on resorting would be the smallest.
Just to clarify,  inserting the node somewhere in the middle, where it fits alphabetically, would minimize the impact on resorting.
Is my understanding correct?

-Swathi
Best regards,
Krzysztof
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help